Show CSS nodes below style sheet editor #3040
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
PR Type: Enhancement
PR Summary: The pull request introduces a feature that displays the CSS node layout for the currently selected element in the diagram below the style editor. This enhancement aims to make it easier for users to understand the CSS nodes associated with diagram items.
Decision: Comment
📝 Type: 'Enhancement' - not supported yet.
- Sourcery currently only approves 'Typo fix' PRs.
✅ Issue addressed: this change correctly addresses the issue or implements the desired feature.
No details provided.
📝 Complexity: the changes are too large or complex for Sourcery to approve.
- Unsupported files: the diff contains files that Sourcery does not currently support during reviews.
General suggestions:
- Ensure that the addition of the
diagramsparameter to thePreferencesStackconstructor is well-documented, as it signifies a more significant role for diagrams in the preferences functionality. - Verify that all methods using
_current_itemproperly handle the case when it isNoneto prevent potentialNoneTypeerrors. - Consider adding an unsubscribe call for
_selection_changedin theclosemethod to avoid memory leaks or unintended behavior after thePreferencesStackis closed. - Review the overall impact of the changes on the application to ensure that the new behavior integrates smoothly with existing features.
Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨
|
This will be very helpful! |
danyeaw
approved these changes
Jan 24, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
What is the current behavior?
It's hard to guess what CSS nodes are part of an item in a diagram.
Issue Number: #3023
What is the new behavior?
Below the style editor, a node layout is given for the currently selected element.