Deal with parameters without a name #3046
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the language of the model.
This way it's clear the name is empty and the TextField doesn't default to the placeholder text.
There was a problem hiding this comment.
PR Type: Bug fix
PR Summary: The pull request aims to address the issue where empty parameter, attribute, operation, and enumeration names were being replaced with placeholder text. The proposed change is to show an empty cell instead.
Decision: Comment
📝 Type: 'Bug fix' - not supported yet.
- Sourcery currently only approves 'Typo fix' PRs.
✅ Issue addressed: this change correctly addresses the issue or implements the desired feature.
No details provided.
✅ Small diff: the diff is small enough to approve with confidence.
No details provided.
General suggestions:
- Ensure that returning a single space instead of an empty string is consistent with the application's handling of null or empty values. This change could have broader implications for UI behavior and data processing.
- Consider the implications of localization for the hardcoded 'New Diagram' string. It may be beneficial to use a localized string to accommodate different languages.
- Review the changes for potential side effects in the UI, particularly where the single space string is used as a default value. It's important to maintain a consistent user experience.
Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
What is the current behavior?
If a parameter/attribute/operation/enumeration name is empty, the placeholder text is shown.
Issue Number: Reported on Matrix
What is the new behavior?
Show an empty cell.
Does this PR introduce a breaking change?
Other information