Run Linux tests on Mutter, instead of Xvfb #3013
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
94f7644 to
345d2b1
Compare
Wayland has the future.
6 tasks
danyeaw
approved these changes
Jan 13, 2024
There was a problem hiding this comment.
Hi @amolenaar, this looks great to me! I noticed that Workbench also recently started using mutter, maybe there is a tip we can learn from their workflow? https://github.com/workbenchdev/Workbench/blob/main/.github/workflows/CI.yaml
|
I think the approach is pretty similar. I prefer executing the tests as sub-process of mutter over starting it as a service. I do not see them launch a dbus session, or XDG_RUNTIME_DIR variable, but I guess that's because they're relying on Flatpak for the testing. |
danyeaw
approved these changes
Jan 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative for #3014
PR Type
What kind of change does this PR introduce?
What is the current behavior?
We use Xvfb for testing in CI
Issue Number: N/A
What is the new behavior?
Use Mutter instead: Wayland has the future.
Does this PR introduce a breaking change?
Other information