Skip to content

Remove use of pipx in CI #3007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 11, 2024
Merged

Remove use of pipx in CI #3007

merged 1 commit into from
Jan 11, 2024

Conversation

danyeaw
Copy link
Member

@danyeaw danyeaw commented Jan 10, 2024

Currently, pipx is failing on CI due to a bug with version 1.4.1. This PR removes use of pipx to straight pip install poetry in the current environment.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bug fix
  • Feature
  • Chore (refactoring, formatting, local variables, other cleanup)
  • Documentation content changes

What is the current behavior?

CI builds are failing due to a pipx not passing the correct path to Python.

Issue Number: N/A

What is the new behavior?

CI builds are passing.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@danyeaw danyeaw added the chore Maintenance related PR label Jan 10, 2024
@danyeaw danyeaw requested a review from amolenaar January 10, 2024 23:12
Copy link
Member

@amolenaar amolenaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. This is actually a nice simplification.

@amolenaar amolenaar merged commit b808de9 into main Jan 11, 2024
@amolenaar amolenaar deleted the remove-pipx branch January 11, 2024 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Maintenance related PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants