Skip to content

CSS for "from: <package>", stereotypes, and compartments #3004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 14, 2024

Conversation

amolenaar
Copy link
Member

@amolenaar amolenaar commented Jan 10, 2024

PR Type

What kind of change does this PR introduce?

  • Bug fix
  • Feature
  • Chore (refactoring, formatting, local variables, other cleanup)
  • Documentation content changes

What is the current behavior?

Issue Number: #3023

What is the new behavior?

Styling for "from: ", stereotypes and compartments can be changed through CSS.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Addition stereotypes are still created by a callable,
so we do not need to rebuild the shape.
@github-actions github-actions bot added the python Pull requests that update Python code label Jan 10, 2024
@amolenaar amolenaar force-pushed the css-from-package branch 2 times, most recently from 8ea8c49 to 4b77d6e Compare January 10, 2024 21:24
@amolenaar amolenaar requested a review from danyeaw January 10, 2024 21:24
Copy link
Member

@danyeaw danyeaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @amolenaar, this looks great! It looks like one of the tests is failing and do we need some sort of doc update to show how this works?

@amolenaar
Copy link
Member Author

I want to have an overview of css nodes in the Property Editor. Kinda like #2750.

Docs need an update, though, I guess :)

@amolenaar amolenaar merged commit fd18927 into main Jan 14, 2024
@amolenaar amolenaar deleted the css-from-package branch January 14, 2024 14:21
@danyeaw danyeaw added feature A new feature and removed python Pull requests that update Python code labels Jan 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants