Add types for parameters #2962
Merged
Add types for parameters #2962
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@amolenaar I think it would be nice to render a label (in, out, inout, return) before the name, but it could be made in a second PR as well. |
|
Added a "Show Direction" option. And fixed the type assignment: type should be assigned to the parameter. |
|
Awesome work! |
|
Thanks 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Types cannot be defined on parameter nodes
Issue Number: #2482
What is the new behavior?
Types are supported.
Does this PR introduce a breaking change?
Other information
@sz332 Should the direction be visible in the diagram as well (similar to
Show Type)?Update: direction can be toggled.