Skip to content

Convert Parameter nodes view to use ColumnView #2957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 25, 2023
Merged

Conversation

amolenaar
Copy link
Member

PR Type

What kind of change does this PR introduce?

  • Bug fix
  • Feature
  • Chore (refactoring, formatting, local variables, other cleanup)
  • Documentation content changes

What is the current behavior?

Parameter Nodes view is still using ListView, while Attributes and Operations is using ColumnView.
This PR makes that consistent.

Issue Number: N/A

What is the new behavior?

Same, but use ColumnView, and reuse the TextField column.

In line with attributes and operations.
@amolenaar amolenaar requested a review from danyeaw December 24, 2023 22:22
@github-actions github-actions bot added the python Pull requests that update Python code label Dec 24, 2023
Copy link
Member

@danyeaw danyeaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @amolenaar!

@danyeaw danyeaw added chore Maintenance related PR and removed python Pull requests that update Python code labels Dec 25, 2023
@danyeaw danyeaw merged commit bf7faa0 into main Dec 25, 2023
@danyeaw danyeaw deleted the parameter-columnview branch December 25, 2023 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Maintenance related PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants