Apply custom window shadow to macOS and Windows #2955
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also the window shadow style now resembles the default shadow style in GTK.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
What is the current behavior?
As discussed in #2952, the shadow for macOS is very wide, and the shadow is drawn as part of the
NSView, hence mouse clicks are consumed.The same issue appears on Windows.
Issue Number: N/A
What is the new behavior?
Update the window shadow style for both macOS and Windows.
The shadow style is now resembling the default shadow style in GTK.
I found that
CssProvider.load_from_path()does not cascade, so only the shadow styling was loaded. This has been fixed.