Skip to content

Be very defensive about settings schema sources #2949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 22, 2023
Merged

Conversation

amolenaar
Copy link
Member

@amolenaar amolenaar commented Dec 22, 2023

PR Type

What kind of change does this PR introduce?

  • Bug fix
  • Feature
  • Chore (refactoring, formatting, local variables, other cleanup)
  • Documentation content changes

What is the current behavior?

App crashes in case there's no default Gio GSettings source.

Issue Number: Reported on Matrix

What is the new behavior?

Be extra defensive about the availability of GSettings sources.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@amolenaar amolenaar requested a review from danyeaw December 22, 2023 12:59
@github-actions github-actions bot added the python Pull requests that update Python code label Dec 22, 2023
Copy link
Member

@danyeaw danyeaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @amolenaar!

@danyeaw danyeaw added fix A fix for a bug and removed python Pull requests that update Python code labels Dec 22, 2023
@danyeaw danyeaw merged commit 462ea29 into main Dec 22, 2023
@danyeaw danyeaw deleted the no-settings-schema branch December 22, 2023 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix A fix for a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants