Skip to content

Fix documentation generation on macOS #2909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 7, 2023
Merged

Fix documentation generation on macOS #2909

merged 2 commits into from
Dec 7, 2023

Conversation

amolenaar
Copy link
Member

PR Type

What kind of change does this PR introduce?

  • Bug fix
  • Feature
  • Chore (refactoring, formatting, local variables, other cleanup)
  • Documentation content changes

What is the current behavior?

Documentions fails to build on macOS

Issue Number: N/A

What is the new behavior?

Documentration builds on macOS.

Additionally, the warnings in https://docs.gaphor.org/en/latest/gaphor-services.html have been silenced.

@github-actions github-actions bot added python Pull requests that update Python code documentation labels Dec 7, 2023
This can be the case for our documentation generation,
since we mock the Gtk module, but not GLib.
@danyeaw danyeaw added fix A fix for a bug and removed python Pull requests that update Python code documentation labels Dec 7, 2023
@danyeaw danyeaw changed the title fix documentation generation on macOS Fix documentation generation on macOS Dec 7, 2023
Copy link
Member

@danyeaw danyeaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

@danyeaw danyeaw merged commit 30f3f1a into main Dec 7, 2023
@danyeaw danyeaw deleted the macos-doc-gen branch December 7, 2023 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix A fix for a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants