Skip to content

Fix connecting lines when model is loaded and documentation updates #2908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 13, 2023
Merged

Fix connecting lines when model is loaded and documentation updates #2908

merged 4 commits into from
Dec 13, 2023

Conversation

amolenaar
Copy link
Member

@amolenaar amolenaar commented Dec 7, 2023 •
edited
Loading

PR Type

What kind of change does this PR introduce?

  • Bug fix
  • Feature
  • Chore (refactoring, formatting, local variables, other cleanup)
  • Documentation content changes

What is the current behavior?

Issue Number: #2816

What is the new behavior?

While adding the requirements diagram I ran into #2768. That's been fixed too.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Dropped my middle name ("J.").

@amolenaar amolenaar marked this pull request as draft December 7, 2023 08:31
@github-actions github-actions bot added translation Everything regarding translation, localization, and internationalization packaging Update to packaging aspects documentation labels Dec 7, 2023
@amolenaar amolenaar linked an issue Dec 7, 2023 that may be closed by this pull request
How come the concept section of the documentation doesn't have a single diagram? #2816
Closed
@github-actions github-actions bot added the python Pull requests that update Python code label Dec 7, 2023
@amolenaar amolenaar changed the title Documentation updates Fix connecting lines when model is loaded and documentation updates Dec 7, 2023
@amolenaar amolenaar linked an issue Dec 7, 2023 that may be closed by this pull request
Connector end moved after reloading a model #2768
Closed
3 tasks
@amolenaar amolenaar marked this pull request as ready for review December 7, 2023 12:01
@amolenaar amolenaar requested a review from danyeaw December 7, 2023 12:01
@amolenaar
Small textual updates in README
f9f5ae3 
Use the same terminology as used on the docs site.
@amolenaar
Drop Arjan's middle name
4370861
danyeaw
danyeaw approved these changes Dec 13, 2023
View reviewed changes
Copy link
Member

@danyeaw danyeaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @amolenaar!

@danyeaw danyeaw merged commit eae4df6 into main Dec 13, 2023
@danyeaw danyeaw deleted the doc-updates branch December 13, 2023 02:07
@danyeaw danyeaw added fix A fix for a bug and removed python Pull requests that update Python code translation Everything regarding translation, localization, and internationalization packaging Update to packaging aspects documentation labels Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danyeaw danyeaw danyeaw approved these changes

Assignees
No one assigned
Labels
fix A fix for a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

How come the concept section of the documentation doesn't have a single diagram? Connector end moved after reloading a model
2 participants
@amolenaar @danyeaw