Fix pipx install error in Linux #2894
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
01b930f to
a2cd062
Compare
a2cd062 to
95e91fd
Compare
95e91fd to
48a3d85
Compare
amolenaar
approved these changes
Dec 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My pipx improvement to use pylauncher to get the Python version from earlier in the year was released in pipx 1.3. This allows us to have common code to install using pipx, but also broke the build in Linux because the Linux runners have pylauncher and we weren't using the
--python 3.12syntax needed.PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Linux build is failing
Issue Number: N/A
What is the new behavior?
Linux build is passing
Does this PR introduce a breaking change?
Other information