Skip to content

Implemented pipeline integrity check during pipeline creation process #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 3, 2018
Merged

Implemented pipeline integrity check during pipeline creation process #96

merged 3 commits into from
Sep 3, 2018

Conversation

michelvocks
Copy link
Member

Fixes #91

Implemented an integrity check during pipeline creation process. Needs to be tested.

@michelvocks michelvocks added the Needs Work The PR still requires some work from the submitter. label Aug 29, 2018
@michelvocks michelvocks self-assigned this Aug 29, 2018
@michelvocks michelvocks force-pushed the inform_user_when_pipe_broken branch from 64381fa to fcda964 Compare August 29, 2018 06:24
@codecov-io
Copy link

codecov-io commented Aug 31, 2018 •
edited
Loading

Codecov Report

Merging #96 into master will increase coverage by 0.13%.
The diff coverage is 44.82%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #96      +/-   ##
==========================================
+ Coverage   64.44%   64.57%   +0.13%     
==========================================
  Files          22       22              
  Lines        1887     1911      +24     
==========================================
+ Hits         1216     1234      +18     
- Misses        539      540       +1     
- Partials      132      137       +5
Impacted Files Coverage Δ
scheduler/scheduler.go 73.83% <ø> (+0.26%) ⬆️
pipeline/ticker.go 4.58% <0%> (+4.58%) ⬆️
pipeline/update_pipeline.go 56.52% <50%> (-1.38%) ⬇️
pipeline/create_pipeline.go 51.25% <55%> (+1.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07cf7a3...0c620db. Read the comment docs.

@michelvocks michelvocks added Ready To Merge PR is ready to be merged into master and removed Needs Work The PR still requires some work from the submitter. labels Sep 1, 2018
@michelvocks michelvocks changed the title [WIP] Implemented pipeline integrity check during pipeline creation process Implemented pipeline integrity check during pipeline creation process Sep 1, 2018
@michelvocks michelvocks requested a review from Skarlso September 1, 2018 20:26
@michelvocks
Copy link
Member Author

@Skarlso This improves a bit the user experience when the pipeline is broken 😄
You can try it with this broken pipeline: https://github.com/michelvocks/gaia-test-pipeline
I just added a dependency which does not exist.

@Skarlso
Copy link
Member

Skarlso commented Sep 3, 2018 •
edited
Loading

LGTM! 👍 Awesome stuff. This improves experience a lot, I think. :)

@Skarlso Skarlso merged commit add96f7 into gaia-pipeline:master Sep 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Skarlso Skarlso Awaiting requested review from Skarlso

Assignees

@michelvocks michelvocks

Labels
Ready To Merge PR is ready to be merged into master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michelvocks @codecov-io @Skarlso