Small Makefile modification to bring down binary size. #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome. 😊 Usually you start the title with WIP (work in progress) so everyone knows that this PR is still in progress. |
|
Good point. :) I have several small Prs now. What I'll do I think is merge them together rather. The make file and a test cleanup together make sense. The way it is right now is too fractured. I'll pull these Prs into one test fix / refactor one. It will be much easier to manage. :) |
|
Oh never mind. You merged the others. :DDDD I'll pull them in here and make the coverage reporter. :) |
|
That sounds great. 😄 |
|
The beginnings: ❯ go test ./... --coverprofile=cover.out
? github.com/gaia-pipeline/gaia [no test files]
? github.com/gaia-pipeline/gaia/cmd/gaia [no test files]
? github.com/gaia-pipeline/gaia/handlers [no test files]
ok github.com/gaia-pipeline/gaia/pipeline 6.957s coverage: 2.5% of statements
? github.com/gaia-pipeline/gaia/plugin [no test files]
ok github.com/gaia-pipeline/gaia/scheduler 0.018s coverage: 16.4% of statements
ok github.com/gaia-pipeline/gaia/store 0.027s coverage: 30.0% of statements |
|
This is done for now. :) |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings down the binary size from 21MB to 11MB.
Also, I'm planning on adding a coverage report for all packages in
test-coverso hold off on merging until then if you so please. :)