Skip to content

Conversation

al3rez
Copy link
Contributor

@al3rez al3rez commented Jul 16, 2018

Due to consistency and convention Go filenames should be in lowercase.

@al3rez
Copy link
Contributor Author

al3rez commented Jul 16, 2018

@rmb938 @michelvocks

@codecov-io
Copy link

Codecov Report

Merging #38 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #38   +/-   ##
======================================
  Coverage    33.5%   33.5%           
======================================
  Files          13      13           
  Lines         991     991           
======================================
  Hits          332     332           
  Misses        622     622           
  Partials       37      37
Impacted Files Coverage Δ
handlers/user.go 27.77% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8729f6b...21d6767. Read the comment docs.

Copy link
Member

@michelvocks michelvocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty sure I was drunk when I did this... 😳
LGTM 🤗

@michelvocks michelvocks merged commit bbf228e into gaia-pipeline:master Jul 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants