Skip to content

Creating github webhook secrets per pipeline #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Aug 7, 2020
Merged

Creating github webhook secrets per pipeline #283

merged 16 commits into from
Aug 7, 2020

Conversation

Skarlso
Copy link
Member

@Skarlso Skarlso commented Aug 6, 2020 •
edited
Loading

TODO

  • Test with all pipeline types
    • Done
      • Ruby
      • Go
      • NodeJS
      • Java
      • Python
      • Cpp
  • Polling, Pull new pipeline and webhook should now update the pipeline data

@Skarlso
Copy link
Member Author

Skarlso commented Aug 6, 2020

/test

@gaia-bot
Copy link

gaia-bot commented Aug 6, 2020

Command received. Building new test image.

@gaia-bot
Copy link

gaia-bot commented Aug 6, 2020

The new test version has been pushed.

@Skarlso
Copy link
Member Author

Skarlso commented Aug 6, 2020

/test

@gaia-bot
Copy link

gaia-bot commented Aug 6, 2020

Command received. Building new test image.

@gaia-bot
Copy link

gaia-bot commented Aug 6, 2020

Failed to push new code to gaia infrastructure repository.

@Skarlso
Copy link
Member Author

Skarlso commented Aug 6, 2020

/test

@gaia-bot
Copy link

gaia-bot commented Aug 6, 2020

Command received. Building new test image.

@gaia-bot
Copy link

gaia-bot commented Aug 6, 2020

The new test version has been pushed.

@Skarlso
Copy link
Member Author

Skarlso commented Aug 6, 2020

/test

1 similar comment
@Skarlso
Copy link
Member Author

Skarlso commented Aug 6, 2020

/test

@gaia-bot
Copy link

gaia-bot commented Aug 6, 2020

Command received. Building new test image.

@gaia-bot
Copy link

gaia-bot commented Aug 6, 2020

The new test version has been pushed.

@Skarlso
Copy link
Member Author

Skarlso commented Aug 6, 2020

/test

@gaia-bot
Copy link

gaia-bot commented Aug 6, 2020

Command received. Building new test image.

@gaia-bot
Copy link

gaia-bot commented Aug 6, 2020

The new test version has been pushed.

@Skarlso
Copy link
Member Author

Skarlso commented Aug 6, 2020

/test

@gaia-bot
Copy link

gaia-bot commented Aug 6, 2020

Command received. Building new test image.

@gaia-bot
Copy link

gaia-bot commented Aug 6, 2020

The new test version has been pushed.

@Skarlso
Copy link
Member Author

Skarlso commented Aug 6, 2020

/test

@gaia-bot
Copy link

gaia-bot commented Aug 6, 2020

Command received. Building new test image.

@gaia-bot
Copy link

gaia-bot commented Aug 6, 2020

The new test version has been pushed.

@gaia-bot
Copy link

gaia-bot commented Aug 6, 2020

Command received. Building new test image.

@codecov-commenter
Copy link

codecov-commenter commented Aug 6, 2020 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 39.39394% with 40 lines in your changes missing coverage. Please review.

Project coverage is 59.58%. Comparing base (62f005c) to head (02dc7e8).
Report is 20 commits behind head on master.

Files with missing lines Patch % Lines
workers/pipeline/git.go 25.00% 17 Missing and 1 partial ⚠️
providers/pipelines/hook.go 42.30% 11 Missing and 4 partials ⚠️
workers/pipeline/build_ruby.go 69.23% 3 Missing and 1 partial ⚠️
workers/pipeline/create_pipeline.go 0.00% 3 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #283      +/-   ##
==========================================
- Coverage   59.76%   59.58%   -0.19%     
==========================================
  Files          58       58              
  Lines        4591     4622      +31     
==========================================
+ Hits         2744     2754      +10     
- Misses       1379     1398      +19     
- Partials      468      470       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gaia-bot
Copy link

gaia-bot commented Aug 6, 2020

The new test version has been pushed.

@Skarlso
Copy link
Member Author

Skarlso commented Aug 6, 2020

/test

@gaia-bot
Copy link

gaia-bot commented Aug 6, 2020

Command received. Building new test image.

@gaia-bot
Copy link

gaia-bot commented Aug 6, 2020

The new test version has been pushed.

@Skarlso
Copy link
Member Author

Skarlso commented Aug 6, 2020

/test

@gaia-bot
Copy link

gaia-bot commented Aug 6, 2020

Command received. Building new test image.

@gaia-bot
Copy link

gaia-bot commented Aug 6, 2020

The new test version has been pushed.

@Skarlso
Copy link
Member Author

Skarlso commented Aug 6, 2020

/test

@gaia-bot
Copy link

gaia-bot commented Aug 6, 2020

Command received. Building new test image.

@gaia-bot
Copy link

gaia-bot commented Aug 6, 2020

The new test version has been pushed.

@Skarlso
Copy link
Member Author

Skarlso commented Aug 7, 2020

/test

@gaia-bot
Copy link

gaia-bot commented Aug 7, 2020

Command received. Building new test image.

@gaia-bot
Copy link

gaia-bot commented Aug 7, 2020

The new test version has been pushed.

@Skarlso
Copy link
Member Author

Skarlso commented Aug 7, 2020

Node needs to wait for a tick for the pipeline to be properly updated... Should document that somewhere 🤔

@Skarlso
Copy link
Member Author

Skarlso commented Aug 7, 2020

/test

@gaia-bot
Copy link

gaia-bot commented Aug 7, 2020

Command received. Building new test image.

@gaia-bot
Copy link

gaia-bot commented Aug 7, 2020

The new test version has been pushed.

@Skarlso
Copy link
Member Author

Skarlso commented Aug 7, 2020

Finally everything works!!!!!!!!!!!!!

@Skarlso Skarlso merged commit ed5c1e2 into master Aug 7, 2020
@Skarlso Skarlso deleted the fix_global_hook_secret branch August 7, 2020 12:18
@Skarlso Skarlso mentioned this pull request Aug 7, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Skarlso @gaia-bot @codecov-commenter