Echo groups (fix #252) #253
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@speza Did you have a chance to test this with a production build of Gaia as well making sure all elements like favico and such are displayed correctly? |
|
@speza I actually started testing this for you. :) I wanted to make sure the build process still works anyways. Don't worry about it. :) |
|
Tested this with a release. Seems to work fine. :) I used the Helm charts and a kubernetes release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So this utilises echo groups to manage what endpoints have the auth middleware applied. This is nice a clean and lets us avoid using the nonProtectedPathsPrefix and nonProtectedPaths slices on every request.
Fixes #252.