Codecov Report

Merging #127 into master will increase coverage by 0.09%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #127      +/-   ##
==========================================
+ Coverage   63.46%   63.56%   +0.09%     
==========================================
  Files          24       24              
  Lines        2116     2116              
==========================================
+ Hits         1343     1345       +2     
+ Misses        618      617       -1     
+ Partials      155      154       -1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b312dd...b7f6134. Read the comment docs.

@GSokol Hi!

thank you for your contribution! At a first glance, could you please remove the accidental swap file .ingress.yaml.swp? :)

Thanks!

I'll review some more later on.

Thanks @GSokol !
I will also participate in this review (#126) :)

Testing:

❯ minikube addons list
- addon-manager: enabled
- coredns: enabled
- dashboard: enabled
- default-storageclass: enabled
- efk: disabled
- freshpod: disabled
- heapster: disabled
- ingress: disabled
- kube-dns: disabled
- metrics-server: disabled
- nvidia-driver-installer: disabled
- nvidia-gpu-device-plugin: disabled
- registry: disabled
- registry-creds: disabled
- storage-provisioner: enabled

❯ kubectl get po -n kube-system
NAME                                    READY   STATUS    RESTARTS   AGE
coredns-c4cffd6dc-6pgtk                 1/1     Running   0          17m
etcd-minikube                           1/1     Running   0          17m
kube-addon-manager-minikube             1/1     Running   0          17m
kube-apiserver-minikube                 1/1     Running   0          16m
kube-controller-manager-minikube        1/1     Running   0          16m
kube-dns-86f4d74b45-r46mm               3/3     Running   0          17m
kube-proxy-bxgrg                        1/1     Running   0          17m
kube-scheduler-minikube                 1/1     Running   0          16m
kubernetes-dashboard-6f4cfc5d87-tfd8s   1/1     Running   0          17m
storage-provisioner                     1/1     Running   0          17m
tiller-deploy-6fd8d857bc-whthh          1/1     Running   0          1m

@GSokol So um.. I don't have the ingress provider.

EDIT oh so I have to create that on my own. Ah..

@GSokol yeah it's not working. I enabled ingress, plus refrained from using dnsmasq. I edited my etc host file to contain it.

You are missing one more step or you did something that is not described here. :)

http://gaia.k8s.dev -- trying to call this redirects to HTTPS which I don't know why because the rules aren't saying that.

The ingress provider isn't created unless I do some magic. Which is I guess fine in some case? Is it created for you or are you doing that by hand somehow?

@Skarlso I really do not remember. I use version 0.25.0. About https -- it seems to me, that's google chrome's problem: kubernetes/ingress-nginx#668.

@Skarlso Oh, sorry! I've found my tpls! Just several minutes!

@GSokol There we go. :P Nice. :) I'll give this a whirl once I get home. Thanks!

@GSokol could you please add the scope as well to the ingress for gaia namespace? That seems to be missing form the commit you made. 😊

@Skarlso

@GSokol could you please add the scope as well to the ingress for gaia namespace? That seems to be missing form the commit you made. 😊

What do you min scope?

@GSokol this stuff: - --watch-namespace=gaia this is scope. And you can add something like this:
controller.scope.enabled
controller.scope.namespace
In helm in order to configure the scope of your ingress.

If you don't do that, that means it will handle everything everywhere. Thus if you have an ingress and you need it only for one namespace you specify a scope. And then you can have multiple ingresses for different scopes.

@Skarlso It's more useful to have only one ingress-controller, that looks for all ingress configs in all namespaces and if you want to disable one, you may do it using helm templates:

{{ if .Values.helm.enabled }}
apiVersion: extensions/v1beta1
kind: Ingress
...
{{ end }}

That's because of ingress-controller is shared resource between different services (and namespaces).

On a large project you can have several with different settings.

https://github.com/helm/charts/tree/master/stable/nginx-ingress

Here, if you look for scope that's what it defines.

Also, this: https://github.com/nginxinc/kubernetes-ingress/tree/master/examples/multiple-ingress-controllers

Also, this: https://kubernetes.github.io/ingress-nginx/deploy/

Where this reads...:

The default configuration watches Ingress object from all the namespaces. To change this behavior use the flag --watch-namespace to limit the scope to a particular namespace.

so, normally, I would like to avoid putting an ingress control into a cluster which uses multiple ones that will catch every namespace. Gaia could maybe be deployed into a cluster which runs several things.

@GSokol Would you like to change something else, or can I merge this? :)