Skip to content

Extracting building logic into a workers package #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 30, 2018
Merged

Extracting building logic into a workers package #115

merged 2 commits into from
Sep 30, 2018

Conversation

Skarlso
Copy link
Member

@Skarlso Skarlso commented Sep 28, 2018

Deals with the first part of #107.

This is a WIP for now. I started moving the building logic into a different package.

@Skarlso Skarlso added the Needs Work The PR still requires some work from the submitter. label Sep 28, 2018
@Skarlso Skarlso requested a review from michelvocks September 28, 2018 18:51
@codecov-io
Copy link

Codecov Report

Merging #115 into master will increase coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #115      +/-   ##
==========================================
+ Coverage   64.51%   64.61%   +0.09%     
==========================================
  Files          24       24              
  Lines        2063     2063              
==========================================
+ Hits         1331     1333       +2     
+ Misses        581      580       -1     
+ Partials      151      150       -1
Impacted Files Coverage Δ
services/service_provider.go 77.77% <ø> (ø) ⬆️
workers/pipeline/build_python.go 83.67% <ø> (ø)
workers/pipeline/update_pipeline.go 56.52% <ø> (ø)
handlers/pipeline.go 39.25% <ø> (ø) ⬆️
workers/pipeline/create_pipeline.go 51.25% <ø> (ø)
workers/pipeline/build_java.go 92.5% <ø> (ø)
workers/pipeline/ticker.go 4.58% <ø> (ø)
handlers/hook.go 62.5% <ø> (ø) ⬆️
workers/scheduler/workload.go 100% <ø> (ø)
plugin/plugin.go 66.93% <ø> (ø) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 753ee64...e53754c. Read the comment docs.

@Skarlso Skarlso added needs review and removed Needs Work The PR still requires some work from the submitter. labels Sep 28, 2018
michelvocks
michelvocks approved these changes Sep 30, 2018
View reviewed changes
Copy link
Member

@michelvocks michelvocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michelvocks michelvocks merged commit 8eb3f1a into gaia-pipeline:master Sep 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michelvocks michelvocks michelvocks approved these changes

Assignees
No one assigned
Labels
needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Skarlso @codecov-io @michelvocks