Skip to content

Fixed permissions on gaia created folders and pipelines. #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 12, 2019
Merged

Fixed permissions on gaia created folders and pipelines. #190

merged 3 commits into from
Jul 12, 2019

Conversation

Skarlso
Copy link
Member

@Skarlso Skarlso commented Jul 12, 2019

Closes #185

golangcibot
golangcibot reviewed Jul 12, 2019
View reviewed changes
@codecov-io
Copy link

codecov-io commented Jul 12, 2019 •
edited
Loading

Codecov Report

Merging #190 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #190      +/-   ##
==========================================
+ Coverage   62.59%   62.62%   +0.02%     
==========================================
  Files          48       48              
  Lines        3914     3914              
==========================================
+ Hits         2450     2451       +1     
+ Misses       1069     1068       -1     
  Partials      395      395
Impacted Files Coverage Δ
handlers/handler.go 89.23% <ø> (ø) ⬆️
workers/pipeline/build_python.go 82.53% <100%> (ø) ⬆️
workers/pipeline/build_nodejs.go 100% <100%> (ø) ⬆️
workers/pipeline/build_java.go 89.13% <100%> (ø) ⬆️
workers/pipeline/build_cpp.go 95.12% <100%> (ø) ⬆️
workers/pipeline/build_golang.go 94.64% <100%> (ø) ⬆️
workers/pipeline/build_ruby.go 69.04% <100%> (ø) ⬆️
workers/agent/agent.go 48.68% <100%> (ø) ⬆️
workers/scheduler/scheduler.go 65.74% <0%> (+0.3%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e766c3d...b666b8e. Read the comment docs.

michelvocks
michelvocks approved these changes Jul 12, 2019
View reviewed changes
Copy link
Member

@michelvocks michelvocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one minor thing and golang CI bot feedback. Otherwise LGTM 😄

golangcibot
golangcibot reviewed Jul 12, 2019
View reviewed changes
@Skarlso Skarlso merged commit 86e92ba into gaia-pipeline:master Jul 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michelvocks michelvocks michelvocks approved these changes

+1 more reviewer

@golangcibot golangcibot golangcibot left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set pipeline binary OS permissions accordingly
4 participants
@Skarlso @codecov-io @michelvocks @golangcibot