Skip to content

Changed unix socket connection to secure, mutual TLS port connection #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Changed unix socket connection to secure, mutual TLS port connection #1

wants to merge 1 commit into from

Conversation

michelvocks
Copy link
Member

No description provided.

@michelvocks michelvocks mentioned this pull request Jul 30, 2018
Merged
@michelvocks michelvocks changed the title [WIP] Changed unix socket connection to secure, mutual TLS port connection Changed unix socket connection to secure, mutual TLS port connection Jul 30, 2018
@michelvocks michelvocks force-pushed the unix_socket_to_port branch from de179c6 to ce924a2 Compare July 30, 2018 19:16
@michelvocks michelvocks requested a review from Skarlso July 30, 2018 19:17
@michelvocks michelvocks self-assigned this Jul 30, 2018
@michelvocks
Copy link
Member Author

@Skarlso this change will also already introduce job parameters. Every job must then accept map[string]string as parameter. What do you think? 🤗

@Skarlso
Copy link
Member

Skarlso commented Jul 31, 2018

@michelvocks Love it!

@michelvocks
Copy link
Member Author

Great. Let's hold this PR until next release.

@michelvocks michelvocks force-pushed the unix_socket_to_port branch 4 times, most recently from f686649 to 373c0fa Compare August 1, 2018 10:51
@michelvocks michelvocks force-pushed the unix_socket_to_port branch from 373c0fa to 9f38d12 Compare August 2, 2018 12:08
@michelvocks
Copy link
Member Author

I will close this PR because it's included in #2

@michelvocks michelvocks closed this Aug 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Skarlso Skarlso Skarlso approved these changes

Assignees

@michelvocks michelvocks

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michelvocks @Skarlso