better numeric_limits<>::max/min fix when using SPDLOG_WCHAR_TO_UTF8_SUPPORT #1819
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What do you mean doesnt work? |
Header only compile was causing issues with that, even with NOMINMAX defined |
|
so why does removing the define fix this? |
It doesn't, the part where I added the parenthesis around std::numeric_limits::max does, and removed the define because it's unnecessary |
|
so lets put it back in, otherwise it might break backward compitability for code that relies on it to be already defined. |
…SUPPORT NOMINMAX macro doesn't work everytime for some reason
|
if there is not any other code using min/max not sure what backward compatibility it could break, but i re-added it |
|
Thanks @nukeulater. Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOMINMAX macro doesn't work everytime for some reason