Skip to content

Warning flags are getting propagated #1825

@prateek9623

Description

@prateek9623

The shared library of spdlog is propagating MSVC warning flags, which is creating issues while compiling my CUDA based application as NVCC don't play well with MSVC warning flags.

So, can we make this PRIVATE

spdlog/CMakeLists.txt

Lines 134 to 136 in ff6e3c9

if(MSVC)
target_compile_options(spdlog PUBLIC /wd4251 /wd4275)
endif()

Environment
OS: Windows
Compiler: MSVC(14.28.29333), NVCC 11.2

To Reproduce
link with CUDA based application using vcpkg

Expected behavior
the warning should not propagate from spdlog

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions