Add test for malformed bodySummary #559
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The documentation comment states: “Will return null if the response is not printable.” but until recently, this was not actually true – the function would gladly return a string truncated in the middle of an Unicode codepoint. 3f849aa fixed that. Let’s add a corresponding test.
691cf6a to
22ee9ae
Compare
GrahamCampbell
requested changes
Apr 17, 2023
GrahamCampbell
approved these changes
Apr 17, 2023
|
Thanks for adding tests here. Much appreciated. 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation comment states: “Will return null if the response is not printable.” but until recently, this was not actually true – the function would gladly return a string truncated in the middle of an Unicode codepoint. 3f849aa fixed that.
Let’s add a corresponding test.