Fixed readme EofCallbackStream example
#545
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On PHP 8.2, if you don't explicitly declare the property, you will get an error like `Deprecated: Creation of dynamic property EofCallbackStream::$stream is deprecated` From what I can tell, other usages in this code base (e.g. https://github.com/guzzle/psr7/blob/b4719a1/src/DroppingStream.php#L15-L21) explicitly add a `$stream` property when they're using `StreamDecoratorTrait`.
GrahamCampbell
requested changes
Dec 27, 2022
GrahamCampbell
approved these changes
Dec 27, 2022
EofCallbackStream example
|
Thanks. |
|
For reference: b4719a1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On PHP 8.2, if you don't explicitly declare the property, you will get an error like
Deprecated: Creation of dynamic property EofCallbackStream::$stream is deprecatedFrom what I can tell, other usages in this code base (e.g. https://github.com/guzzle/psr7/blob/b4719a1/src/DroppingStream.php#L15-L21) explicitly add a
$streamproperty when they're usingStreamDecoratorTrait.