Skip to content

Conversation

chetan-prime
Copy link
Contributor

Add ability like json.Number for .Float and .Int to handle numbers that come in as strings from the browser

@guregu
Copy link
Owner

guregu commented Jun 13, 2017

Looks good to me, could you add some tests?

@chetan-prime
Copy link
Contributor Author

Thanks , will add some code for testing json strings --> floats & ints

@chetan-prime
Copy link
Contributor Author

The tests pass for me. I am not sure if I have covered all possibilities though

@guregu
Copy link
Owner

guregu commented Jun 19, 2017

Thanks, I'll take a look soon

@chetan-prime
Copy link
Contributor Author

Any issues with the code ? I have been using it for a few projects here and so far its been fine

@suntong
Copy link

suntong commented Aug 20, 2017

Looks good and useful to me, too.

Hope it'll get merged soon.

@guregu guregu merged commit ee66bfb into guregu:master Aug 20, 2017
@guregu
Copy link
Owner

guregu commented Aug 20, 2017

Sorry for the wait. I made added some tests and ran gofmt. I also added the equivalent changes to the zero package.

@suntong
Copy link

suntong commented Aug 20, 2017

Wow, impressive, 👍

@suntong
Copy link

suntong commented Aug 20, 2017

Oh, forgot to say,

maybe we should put json as well into github topics on the top of project page...

@chetan-prime
Copy link
Contributor Author

Thanks, good to know that the functionality is now part of the master repo.
The wait was well worth it as I know its important not to make breaking changes for others using the same library

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants