-
-
Notifications
You must be signed in to change notification settings - Fork 246
Code for .Float and .Int to handle numbers that come in as strings from json #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…at come in as strings from the browser (very useful)
Looks good to me, could you add some tests? |
Thanks , will add some code for testing json strings --> floats & ints |
The tests pass for me. I am not sure if I have covered all possibilities though |
Thanks, I'll take a look soon |
Any issues with the code ? I have been using it for a few projects here and so far its been fine |
Looks good and useful to me, too. Hope it'll get merged soon. |
Sorry for the wait. I made added some tests and ran gofmt. I also added the equivalent changes to the zero package. |
Wow, impressive, 👍 |
Oh, forgot to say, maybe we should put |
Thanks, good to know that the functionality is now part of the master repo. |
Add ability like json.Number for .Float and .Int to handle numbers that come in as strings from the browser