Null check before dispose ProjectContainer
#90
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added to prevent null reference exceptions when ProjectContainer is null due to container build failure. Such check shouldn't affect performance in any way, because happens only once when project container is disposed meaning end of app run.
gustavopsantos
approved these changes
May 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
It seems there are cases when ProjectContainer is null due to some exception during container build stage. So quitting play mode cause call
ProjectContainer.Disposeon null.ProjectContainer?.Disposesimply check for null before call method, which prevent such exceptions.Fixes # (issue)
In some cases after exiting play mode we get NullRefernceException due to null ProjectContainer
Type of change
How Has This Been Tested?
After code change I've run unit tests and also Reflex.Sample scene. All goes fine.
Checklist:
Reflex.Sample)