feat: new CI #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

gustavovalverde wants to merge 43 commits into main from ci-overhaul

+1,348 −2,263

Owner

gustavovalverde commented Aug 27, 2025

Motivation

Solution

Tests

Specifications & References

Follow-up Work

PR Checklist

The PR name is suitable for the release notes.
The solution is tested.
The documentation is up to date.


          feat: new CI

ac98211

github-actions bot added the C-feature label

github-advanced-security bot found potential problems

View reviewed changes

.github/workflows/lint-codebase.yml Fixed Show fixed Hide fixed

.github/workflows/lint-codebase.yml Fixed Show fixed Hide fixed

.github/workflows/lint-codebase.yml Fixed Show fixed Hide fixed

.github/workflows/lint-codebase.yml Fixed Show fixed Hide fixed

.github/workflows/lint-codebase.yml Fixed Show fixed Hide fixed

.github/workflows/lint-codebase.yml Fixed Show fixed Hide fixed

.github/workflows/lint-codebase.yml Fixed Show fixed Hide fixed

.github/workflows/lint-codebase.yml Fixed Show fixed Hide fixed

.github/workflows/lint-codebase.yml Fixed Show fixed Hide fixed

.github/workflows/lint-codebase.yml Fixed Show fixed Hide fixed


          fix: zizmor

d848cd2

github-advanced-security bot found potential problems

View reviewed changes

.github/workflows/lint-codebase.yml Fixed Show fixed Hide fixed


          fix: linters

329584c

github-advanced-security bot found potential problems

View reviewed changes

.github/workflows/lint-codebase.yml Fixed Show fixed Hide fixed

gustavovalverde added 22 commits

August 27, 2025 08:47


          chore: simplify workflows

f68cf7b


          fix: minimum permissions

ddb3dc2


          refactor: remove old action

42a90ef


          feat: simpler tests

57974a2


          chore: increase scope and fix error

917e486


          fix(lint): clippy::result_large_err by boxing large error variant f…

737325a

…ields

- Box large fields in ValidateContextError::AddValuePool variant
- Box ValidateContextError in wrapper error types
- Update error construction sites to use Box::new()


          fix: test selection

3068e54


          fix: update the test all profile

bd2a1c0


          fix: run ignored tests for OS testing

2a877c8


          chore: cleanups and windows improvements

f90e09b


          fix: format

029cdd8


          fix: linter

3acd287


          fix: skip slow tests in Windows

644a332


          fix: cargo doc command

020f2b0


          fix: use more specific cache-keys

3013e11


          fix: unit test names

4bf48a5


          feat: add coverage.yml workflow for test coverage reporting

6f1cc70


          fix: docs building

75c5653


          fix: do not run delete_old_databases on windows

ee69bd0


          chore: remove previous jobs

f1d72c3


          fix: nextest profile

a0516bb


          feat: new docker test workflow with local image

3a08c34

github-advanced-security bot found potential problems

View reviewed changes

.github/workflows/test-docker-config.yml Fixed Show fixed Hide fixed

.github/workflows/test-docker-config.yml Fixed Show fixed Hide fixed

gustavovalverde added 3 commits

August 28, 2025 07:03


          fix: simpler docker

1e3f41c


          fix: build

6bb550e


          fix: book

a670acb

gustavovalverde had a problem deploying to github-pages

August 28, 2025 09:53

— with

GitHub Actions Failure


          fix: use correct docker image tag reference

df0d8c0

gustavovalverde had a problem deploying to github-pages

August 28, 2025 10:04

— with

GitHub Actions Failure

gustavovalverde added 4 commits

August 28, 2025 11:31


          imp: build both sites in a single page


          fix: use nighly compiler

98c8c88


          chore: cleanup docs workflows

5bfeeae


          fix: run coverage with nextest

4f34997

github-advanced-security bot found potential problems

View reviewed changes

.github/workflows/release-binaries.yml Fixed Show fixed Hide fixed

.github/workflows/release-binaries.yml Fixed Show fixed Hide fixed

gustavovalverde added 3 commits

August 28, 2025 13:54


          fix: book linting errors

65eb82e


          fix: workflow errors

9745d0c


          fix: docs lint

9aca8f7

github-advanced-security bot found potential problems

View reviewed changes

.github/workflows/release-binaries.yml

Comment on lines +31 to +45

+                dockerhub-description:
+                  if: github.repository_owner == 'ZcashFoundation'
+                  runs-on: ubuntu-latest
+                  steps:
+                    - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 #v5.0.0
+                      with:
+                        persist-credentials: false
+                    - name: Docker Hub Description
+                      uses: peter-evans/dockerhub-description@432a30c9e07499fd01da9f8a49f0faf9e0ca5b77 #v4.0.2
+                      with:
+                        username: ${{ secrets.DOCKERHUB_USERNAME }}
+                        password: ${{ secrets.DOCKERHUB_PASSWORD }}
+                        repository: zfnd/zebra
+                        short-description: ${{ github.event.repository.description }}

Check warning

Code scanning / zizmor

overly broad permissions Warning

overly broad permissions


          fix: more doc linting issues

7bb52cf

gustavovalverde temporarily deployed to github-pages

August 28, 2025 13:11

— with

GitHub Actions Inactive


          fix: identify ZFND specific workflows

c6f7bd6

gustavovalverde temporarily deployed to github-pages

August 28, 2025 13:43

— with

GitHub Actions Inactive

github-advanced-security bot found potential problems

View reviewed changes

.github/workflows/ci-tests.yml Fixed Show fixed Hide fixed

.github/workflows/ci-tests.yml Fixed Show fixed Hide fixed

.github/workflows/release-binaries.yml

@@ @@ -18,7 +18,7 @@ @@
                 # The image will be named `zebra:<semver>`
                 build:
                   name: Build Release Docker
-                  uses: ./.github/workflows/sub-build-docker-image.yml
+                  uses: ./.github/workflows/zfnd-build-docker-image.yml

Check warning

Code scanning / zizmor

secrets unconditionally inherited by called workflow Warning

secrets unconditionally inherited by called workflow

.github/workflows/zfnd-ci-integration-tests-gcp.yml

@@ @@ -70,7 +70,7 @@ @@
                 sync-to-mandatory-checkpoint:
                   name: Zebra checkpoint
                   needs: [get-available-disks]
-                  uses: ./.github/workflows/sub-deploy-integration-tests-gcp.yml
+                  uses: ./.github/workflows/zfnd-deploy-integration-tests-gcp.yml

Check warning

Code scanning / zizmor

secrets unconditionally inherited by called workflow Warning

secrets unconditionally inherited by called workflow

.github/workflows/zfnd-ci-integration-tests-gcp.yml

@@ @@ -97,7 +97,7 @@ @@
                 sync-past-mandatory-checkpoint:
                   name: Zebra checkpoint update
                   needs: [sync-to-mandatory-checkpoint, get-available-disks]
-                  uses: ./.github/workflows/sub-deploy-integration-tests-gcp.yml
+                  uses: ./.github/workflows/zfnd-deploy-integration-tests-gcp.yml

Check warning

Code scanning / zizmor

secrets unconditionally inherited by called workflow Warning

secrets unconditionally inherited by called workflow

.github/workflows/zfnd-ci-integration-tests-gcp.yml

@@ @@ -363,7 +363,7 @@ @@
                 lwd-rpc-send-tx:
                   name: Lightwalletd send transactions
                   needs: [lwd-sync-full, get-available-disks]
-                  uses: ./.github/workflows/sub-deploy-integration-tests-gcp.yml
+                  uses: ./.github/workflows/zfnd-deploy-integration-tests-gcp.yml

Check warning

Code scanning / zizmor

secrets unconditionally inherited by called workflow Warning

secrets unconditionally inherited by called workflow

.github/workflows/zfnd-ci-integration-tests-gcp.yml

@@ @@ -386,7 +386,7 @@ @@
                 lwd-grpc-wallet:
                   name: lightwalletd GRPC tests
                   needs: [lwd-sync-full, get-available-disks]
-                  uses: ./.github/workflows/sub-deploy-integration-tests-gcp.yml
+                  uses: ./.github/workflows/zfnd-deploy-integration-tests-gcp.yml

Check warning

Code scanning / zizmor

secrets unconditionally inherited by called workflow Warning

secrets unconditionally inherited by called workflow

.github/workflows/zfnd-ci-integration-tests-gcp.yml

@@ @@ -413,7 +413,7 @@ @@
                 rpc-get-block-template:
                   name: get block template
                   needs: [sync-full-mainnet, get-available-disks]
-                  uses: ./.github/workflows/sub-deploy-integration-tests-gcp.yml
+                  uses: ./.github/workflows/zfnd-deploy-integration-tests-gcp.yml

Check warning

Code scanning / zizmor

secrets unconditionally inherited by called workflow Warning

secrets unconditionally inherited by called workflow

.github/workflows/zfnd-ci-integration-tests-gcp.yml

@@ @@ -436,7 +436,7 @@ @@
                 rpc-submit-block:
                   name: submit block
                   needs: [sync-full-mainnet, get-available-disks]
-                  uses: ./.github/workflows/sub-deploy-integration-tests-gcp.yml
+                  uses: ./.github/workflows/zfnd-deploy-integration-tests-gcp.yml

Check warning

Code scanning / zizmor

secrets unconditionally inherited by called workflow Warning

secrets unconditionally inherited by called workflow

.github/workflows/zfnd-deploy-nodes-gcp.yml

@@ @@ -159,7 +159,7 @@ @@
                 # The image will be commonly named `zebrad:<short-hash | github-ref | semver>`
                 build:
                   name: Build CD Docker
-                  uses: ./.github/workflows/sub-build-docker-image.yml
+                  uses: ./.github/workflows/zfnd-build-docker-image.yml

Check warning

Code scanning / zizmor

secrets unconditionally inherited by called workflow Warning

secrets unconditionally inherited by called workflow


          feat: simplify crate build

7fec5c1

gustavovalverde temporarily deployed to github-pages

August 28, 2025 15:01

— with

GitHub Actions Inactive

github-advanced-security bot found potential problems

View reviewed changes

.github/workflows/test-crate-build.yml Fixed Show fixed Hide fixed

.github/workflows/test-crate-build.yml Fixed Show fixed Hide fixed

.github/workflows/test-crate-build.yml Fixed Show fixed Hide fixed

.github/workflows/test-crate-build.yml Fixed Show fixed Hide fixed

.github/workflows/test-crate-build.yml Fixed Show fixed Hide fixed

.github/workflows/test-crate-build.yml Fixed Show fixed Hide fixed

.github/workflows/test-crate-build.yml Fixed Show fixed Hide fixed

.github/workflows/test-crate-build.yml Fixed Show fixed Hide fixed


          create a single integration tests workflow

e6629d5

github-advanced-security bot found potential problems

View reviewed changes

.github/workflows/zfnd-ci-integration-tests-gcp.yml

+                  permissions:
+                    id-token: write
+                    statuses: write
+                  uses: ./.github/workflows/zfnd-build-docker-image.yml

Check warning

Code scanning / zizmor

secrets unconditionally inherited by called workflow Warning

secrets unconditionally inherited by called workflow

gustavovalverde temporarily deployed to github-pages

August 28, 2025 20:14

— with

GitHub Actions Inactive

gustavovalverde added 2 commits

August 28, 2025 21:17


          use better names

dc041af


          remove extra workflow

6f9c14d

gustavovalverde deployed to github-pages

August 28, 2025 20:19

— with

GitHub Actions View deployment

gustavovalverde mentioned this pull request

Decide on how to incorporate upstream CI, then do it. ShieldedLabs/zebra-crosslink#194

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels