on("end", fn ()) does not appear to be working correctly #1637
Description
Someone raised an issue in gulp-jasmine (sindresorhus/gulp-jasmine#69) about the end event, and it seems to be caused by gulp:
gulp.task("default", function (callback) {
gulp.src("test.spec.js")
.on("end", function () {
console.log("We're done!");
callback();
});
});works with gulp@3.7 but stopped working with gulp@3.8.
Returning the pipe:
gulp.task("default", function () {
return gulp.src("test.spec.js")
.on("end", function () {
console.log("We're done!");
});
});works as expected. Not sure if I'm missing something (I rarely use callbacks).