feat: Follow to Windows File system behaviour (case-insesitive) #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates path equality logic to match Windows file system behavior and refines associated tests and logging messages.
- Updates PathEquals to perform case-insensitive comparisons on Windows.
- Adjusts test case descriptions and expected outcomes to reflect platform-specific behavior.
- Refines logging messages in file linking and main command execution.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| utils/path_utils_test.go | Modified test names and expected values to reflect platform-specific behavior. |
| utils/path_utils.go | Updated comparison logic to use case-insensitive checking on Windows. |
| services/filelinker_service.go | Changed log message placement, which may cause duplicate messages in dry runs. |
| cmd/dotfileslinker/main.go | Updated dry run logging behavior to now conditionally log success messages. |
Comments suppressed due to low confidence (2)
utils/path_utils_test.go:38
- The updated test description clearly indicates platform-specific behavior; ensure that the message consistently conveys the expected behavior on each platform.
name: "Case difference (should be different on Unix, same on Windows)",
cmd/dotfileslinker/main.go:62
- With the revised logic, dry run scenarios do not log a success message; consider adding a corresponding log entry for dry runs to provide clear feedback to users.
if !dryRun {
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.