ci: NativeAot build should not use condition #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR addresses the CI configuration for NativeAOT builds by updating archive creation steps in the release workflow.
- Changes the conditions for archive creation steps
- Updates the archive paths for Windows and Linux/macOS builds
Files not reviewed (1)
- src/DotfilesLinker/DotfilesLinker.csproj: Language not supported
Comments suppressed due to low confidence (1)
.github/workflows/release.yaml:59
- The Windows archive step now compresses from './publish/publish/...' with a potential duplicate 'publish' directory. Verify that the intended directory structure is correct.
run: Compress-Archive -Path ./publish/publish/DotfilesLinker/release_${{ matrix.rid }}/* -DestinationPath ${{ matrix.archive_name }}
There was a problem hiding this comment.
Pull Request Overview
This PR refines the CI workflow for the NativeAot build by updating condition expressions and revising artifact archiving and checksum generation steps.
- Updates condition expressions to use GitHub Actions expression syntax.
- Adjusts archive paths and adds checksum generation to ensure artifacts are properly validated before release.
Files not reviewed (1)
- src/DotfilesLinker/DotfilesLinker.csproj: Language not supported
Comments suppressed due to low confidence (2)
.github/workflows/release.yaml:55
- The removal of the 'working-directory' field may cause the dotnet publish command to run in an unintended directory. Please ensure that this change is intentional and that the correct working directory is used.
working-directory: ./src/DotfilesLinker
.github/workflows/release.yaml:59
- The updated archive path contains a duplicated 'publish' folder segment ('./publish/publish/'). Verify that this double nesting correctly reflects the output directory structure produced by the dotnet publish command.
run: Compress-Archive -Path ./publish/publish/DotfilesLinker/release_${{ matrix.rid }}/* -DestinationPath ${{ matrix.archive_name }}
There was a problem hiding this comment.
Pull Request Overview
This PR revises the release workflow by modifying the artifact publishing and archiving steps, and by adding pre-release artifact validation and checksum generation.
- Removed the Native AOT build condition flag and adjusted the publish command.
- Updated archive creation commands for both Windows and Linux environments.
- Introduced an artifact existence check and a new checksum generation step.
Files not reviewed (1)
- src/DotfilesLinker/DotfilesLinker.csproj: Language not supported
Comments suppressed due to low confidence (1)
.github/workflows/release.yaml:63
- The tar command for Linux appears to use an inconsistent directory path ('./publish/publish/...') compared to the Windows archive step which uses './artifacts/publish/...'. Please verify the intended artifact directory and update the path accordingly.
run: tar -czvf ${{ matrix.archive_name }} -C ./publish/publish/DotfilesLinker/release_${{ matrix.rid }} .
There was a problem hiding this comment.
Pull Request Overview
This PR updates the release workflow by removing the NativeAOT build condition and standardizing the artifact directory.
- Removed the AOT-specific dotnet publish flag and working-directory for the DotfilesLinker project.
- Updated archive creation steps to reference the new artifacts structure and OS-specific conditionals.
- Added a step to verify artifact existence and generate checksums for the release.
Files not reviewed (1)
- src/DotfilesLinker/DotfilesLinker.csproj: Language not supported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.