feat: Add OS Specific files defaultIgnore, dry-run support #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the file linking service by introducing default OS-specific ignore patterns and a dry-run mode for safer execution. Key changes include:
- Addition of a static default ignore pattern set that covers OS-specific files and wildcards.
- Incorporation of a dry-run mode throughout the file linking process with appropriate logging.
- Updates and new tests to exercise the new functionalities and validate ignore pattern matching logic.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/DotfilesLinker/Services/FileLinkerService.cs | Adds default ignore patterns, dry-run mode support, and updates file processing logic. |
| src/DotfilesLinker/Program.cs | Includes dry-run mode flag parsing and updated command execution. |
| src/DotfilesLinker.Tests/FileLinkerServiceTests.cs | Extends tests for OS-specific ignore patterns and user-defined expectations. |
| src/DotfilesLinker.Tests/FileLinkerServicePatternTests.cs | Provides additional unit tests for ignore pattern matching including wildcards. |
| src/DotfilesLinker.Tests/DryRunTests.cs | Adds tests to confirm dry-run behavior prevents file system changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.