ci: cosign artifact #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR introduces additional security measures by integrating Cosign for artifact signing and SBOM generation into the project’s documentation and CI release pipeline. The key changes include:
- Adding "Security" sections to both the English and Japanese README files with instructions for verifying artifact signatures using Cosign.
- Updating the GitHub release workflow to install Cosign and Syft, generate checksums and SBOMs, sign artifacts and SBOM files, and clean up sensitive files after the release process.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| README_ja.md | Added a "セキュリティ" section with Cosign verification details |
| README.md | Added a "Security" section with Cosign verification details |
| .github/workflows/release.yaml | Added steps to install Cosign & Syft, generate SBOMs, sign artifacts, and clean up sensitive keys |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new Security section to the documentation and augments the release process to digitally sign artifacts using Cosign and generate SBOMs using Syft. Key changes include:
- Adding a "Security" section with instructions for verifying artifact signatures in both README and README_ja.
- Enhancing the GitHub release workflow to install Cosign and Syft, generate checksums and SBOMs, sign artifacts and SBOMs, and clean up sensitive key files.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| README_ja.md | Adds a Security section with Cosign instructions for artifact verification. |
| README.md | Adds a Security section with Cosign instructions for artifact verification. |
| .github/workflows/release.yaml | Updates release workflow to install Cosign/Syft, sign artifacts/SBOMs, and clean up keys. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.