ci: update release #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR aims to update the CI pipelines for release and build jobs while also updating the copilot instructions for formatting and linting.
- Updated release workflow to support multiple operating systems and to improve artifact handling and release creation.
- Revised build workflow by renaming it from "Release" to "Build" and adding restore, build, test, and publish steps.
- Enhanced copilot instructions to include formatting and linting guidelines for C# and GitHub Actions.
Reviewed Changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/release.yaml | Adds a matrix strategy for multiple OS builds, updates publish steps, and adjusts timeout and artifact handling for release creation. |
| .github/workflows/build.yaml | Renames the workflow to Build and refines steps including restore, build, test, and publish. |
| .github/copilot-instructions.md | Updates the CI guidelines to include code formatting and linting instructions. |
Files not reviewed (2)
- src/DotfilesLinker.Tests/DotfilesLinker.Tests.csproj: Language not supported
- src/DotfilesLinker/DotfilesLinker.csproj: Language not supported
Comments suppressed due to low confidence (1)
.github/workflows/release.yaml:14
- [nitpick] The OS identifier 'windows-2025' might be confusing compared to conventional runner names. Consider adding a clarifying comment or using a more standard identifier if applicable.
- - os: windows-2025
|
windows-2025 is valid os for GitHub Actions. |
There was a problem hiding this comment.
Pull Request Overview
This PR updates the CI configuration to improve release and build processes. Key changes include:
- Updating the release workflow to incorporate a matrix strategy for multiple OS targets, adjusting timeout settings, and enhancing artifact creation and release steps.
- Renaming and expanding the build workflow to include restoration, build, test, and publish steps along with a marker job for PR status checks.
- Standardizing dependency update configurations and updating Copilot instructions for formatting and linting.
Reviewed Changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/release.yaml | Updated to use a matrix strategy, enhanced artifact handling, and release creation logic. |
| .github/workflows/build.yaml | Renamed workflow and expanded steps to cover restore, build, test, and publish. |
| .github/dependabot.yaml | Standardized dependency naming and added nuget ecosystem updates. |
| .github/copilot-instructions.md | Added instructions for C# formatting and GitHub Actions linting. |
Files not reviewed (2)
- src/DotfilesLinker.Tests/DotfilesLinker.Tests.csproj: Language not supported
- src/DotfilesLinker/DotfilesLinker.csproj: Language not supported
Comments suppressed due to low confidence (1)
.github/workflows/build.yaml:11
- [nitpick] The job name 'build-test' is somewhat ambiguous given it handles multiple responsibilities (build, test, and publish). Consider renaming it to a more descriptive name such as 'build-test-publish' to improve clarity.
build-test:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.