feat: add --version and --verbose options #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR introduces support for the --version and --verbose command-line options while improving logging across the application. Key changes include:
- Adding an optional ILogger parameter (with a default NullLogger) to FileLinkerService and logging enhancements.
- Implementing new command-line options (--help, --version, --verbose) in Program.cs with corresponding help and version displays.
- Adding support for reading file lines via IFileSystem and updating tests to cover the new ReadAllLines functionality.
Reviewed Changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/DotfilesLinker/Services/FileLinkerService.cs | Updated constructor and logging statements for better traceability. |
| src/DotfilesLinker/Services/ConsoleLogger.cs | Introduced new ConsoleLogger using primary constructor syntax. |
| src/DotfilesLinker/Program.cs | Added command-line options and help/version display logic. |
| src/DotfilesLinker/Infrastructure/IFileSystem.cs | Added a new ReadAllLines method in the file system abstraction. |
| src/DotfilesLinker/Infrastructure/DefaultFileSystem.cs | Implemented ReadAllLines using File.ReadAllLines. |
| src/DotfilesLinker.Tests/FileSystemTests.cs | Added tests for the new ReadAllLines method. |
| src/DotfilesLinker.Tests/FileLinkerServiceTests.cs | Adjusted tests to reflect ignore file handling changes. |
| README_JP.md | Updated documentation in Japanese with repository details. |
| README.md | Revised quick start instructions and examples for clarity. |
| .github/workflows/release.yaml | Updated publish command to include TAG for versioning. |
Files not reviewed (1)
- src/DotfilesLinker/DotfilesLinker.csproj: Language not supported
| drwxr-xr-x 3 root root 4096 Mar 27 02:33 .. | ||
| -rw-r--r-- 1 guitarrapc guitarrapc 4015 Mar 27 02:38 .bashrc | ||
| lrwxrwxrwx 1 guitarrapc guitarrapc 64 Mar 27 02:38 .bashrc_custom -> /home/guitarrapc/github/guitarrapc/dotfiles/.bashrc_custom | ||
| lrwxrwxrwx 1 guitarrapapc 60 Mar 27 02:38 .gitconfig -> /home/guitarrapc/github/guitarrapc/dotfiles/.gitconfig |
There was a problem hiding this comment.
The username 'guitarrapapc' appears to be a typo; please verify if it should be 'guitarrapc'.
Suggested change
| lrwxrwxrwx 1 guitarrapapc 60 Mar 27 02:38 .gitconfig -> /home/guitarrapc/github/guitarrapc/dotfiles/.gitconfig | |
| lrwxrwxrwx 1 guitarrapc guitarrapc 60 Mar 27 02:38 .gitconfig -> /home/guitarrapc/github/guitarrapc/dotfiles/.gitconfig |
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.