Skip to content

Conversation

sureshdsk
Copy link
Contributor

fixes #40

  • added poetry dependancy cache for github workflow

@sureshdsk
Copy link
Contributor Author

@guilatrova please take a look at this PR!

@guilatrova
Copy link
Owner

Hi @sureshdsk
Do you mind reviewing the https://github.com/guilatrova/tryceratops/blob/38bd6cdb95e57bd9674fd5b061abef63ec94c85e/docs/CONTRIBUTING.md#conventional-commits ? The PR needs to follow the conventional commits to generate proper documentatio.

@sureshdsk sureshdsk force-pushed the peotry-cache branch 3 times, most recently from 0f3b5b1 to 91bd407 Compare March 21, 2022 05:56
@sureshdsk
Copy link
Contributor Author

@guilatrova rebased and updated commit messages!

@guilatrova
Copy link
Owner

@sureshdsk All commits should be starting with just ci: because otherwise, it will generate a new release (even though there's no real feature).

@sureshdsk
Copy link
Contributor Author

@guilatrova updated

@guilatrova
Copy link
Owner

@sureshdsk It's failing :(

@sureshdsk
Copy link
Contributor Author

@guilatrova sorry about that :(
This is was not there when I raised the PR initially. This error is due to recent change in black(click's latest release broke) as reported here psf/black#2964

Updating black to 22.3.0 as suggested in the issue.

but another error in mypy is popping up in local, But i haven't changed any python code. but passed from CI run https://github.com/sureshdsk/tryceratops/actions/runs/2182427398

src/tryceratops/__main__.py:26: error: Argument 1 to "Choice" has incompatible type "Set[str]"; expected "Sequence[str]"

@guilatrova
Copy link
Owner

@sureshdsk Fixing mypy is on my list... For now I'm merging it as is. Thank you very much for your patience and support on making Tryceratops better! 🥳

@guilatrova guilatrova merged commit b6a12a4 into guilatrova:main Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add dependency caching for faster builds
2 participants