Skip to content

ui: fix centering of guardicore logo #928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 27, 2021
Merged

ui: fix centering of guardicore logo #928

merged 1 commit into from
Jan 27, 2021

Conversation

mssalvatore
Copy link
Collaborator

@mssalvatore mssalvatore commented Jan 20, 2021 •
edited
Loading

Fixes #612

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the documentation framework updated to reflect the changes? (N/A)

Testing Checklist

  • Added relevant unit tests? (N/A)
  • Have you successfully tested your changes locally? Elaborate:

    Tested by running the monkey locally and comparing screenshots

  • If applicable, add screenshots or log transcripts of the feature working

Screenshots

Stacked

Before

before_stacked

After

after_stacked

Inline (Expected to be identical)

Before

before_inline

After

after_inline

@mssalvatore mssalvatore requested a review from acepace January 20, 2021 15:50
@codecov
Copy link

codecov bot commented Jan 20, 2021 •
edited
Loading

Codecov Report

Merging #928 (3aa8b4a) into develop (b191eff) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #928   +/-   ##
========================================
  Coverage    18.54%   18.54%           
========================================
  Files          338      338           
  Lines        11483    11483           
========================================
  Hits          2130     2130           
  Misses        9353     9353

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b191eff...3aa8b4a. Read the comment docs.

@mssalvatore mssalvatore requested a review from VakarisZ January 25, 2021 15:41
@mssalvatore mssalvatore merged commit 6719620 into develop Jan 27, 2021
@mssalvatore mssalvatore deleted the issue-612 branch January 27, 2021 12:27
@snyk-bot snyk-bot mentioned this pull request May 23, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VakarisZ VakarisZ VakarisZ approved these changes

@acepace acepace Awaiting requested review from acepace

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Guardicore logo is not centered on smaller screens.
2 participants
@mssalvatore @VakarisZ