Catch exceptions in AwsInstance and AzureInstance #924
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #924 +/- ##
===========================================
+ Coverage 19.07% 19.81% +0.73%
===========================================
Files 338 338
Lines 11482 11484 +2
===========================================
+ Hits 2190 2275 +85
+ Misses 9292 9209 -83
Continue to review full report at Codecov.
|
VakarisZ
reviewed
Jan 18, 2021
|
Can we add a test to ensure this issue doesn't get accidentally reintroduced in the future? |
mssalvatore
requested changes
Jan 26, 2021
c4522a5 to
9bb7332
Compare
0c7cc38 to
eed5ea1
Compare
and change urllib.request.urlopen() to requests.get() for easier testing; functionality doesn't change
mssalvatore
requested changes
Feb 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #902
and adds tests for all the cloud instance classes (
common/cloud/*)