Run on AWS instance option fix #867
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #867 +/- ##
========================================
Coverage 60.52% 60.52%
========================================
Files 165 165
Lines 4948 4948
========================================
Hits 2995 2995
Misses 1953 1953 Continue to review full report at Codecov.
|
…s updated, descriptions updated)
VakarisZ
commented
Oct 22, 2020
| let checkboxTable = null; | ||
|
|
||
| function toggleSelection(key) { | ||
| key = key.replace('select-', ''); |
There was a problem hiding this comment.
Maybe that's why it wasn't working before. AWS changed the format of instance ID's returned and it broke? This line compensates the change
acepace
reviewed
Nov 30, 2020
| @@ -0,0 +1,9 @@ | |||
| import {FontAwesomeIcon} from '@fortawesome/react-fontawesome'; | |||
| import {faSync} from '@fortawesome/free-solid-svg-icons'; | |||
| import React from 'react'; | |||
There was a problem hiding this comment.
Nit: Do we need all of react imported there?
|
@VakarisZ this looks good, how did you verify it works? Because not sure I can easily test |
|
I ran it on AWS |
|
Then no comment preventing. Anyone? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #865
PR Checklist
Testing Checklist
Explain Changes
In addition moved run page files around, fixed eslint not to warn about backtick usage.