Skip to content

Added windows XP support for win_ms08_067 #809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 1, 2020
Merged

Added windows XP support for win_ms08_067 #809

merged 1 commit into from
Sep 1, 2020

Conversation

VakarisZ
Copy link
Contributor

What does this PR do?

Added windows XP support for win_ms08_067 and fixed exploited/not exploited logic

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?

Testing Checklist

  • Have you successfully tested your changes locally? Elaborate:

    Tested by running on exploitable windows XP machine (SP2) and non exploitable (updated SP3)

@codecov
Copy link

codecov bot commented Aug 28, 2020

Codecov Report

Merging #809 into develop will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #809      +/-   ##
===========================================
- Coverage    60.46%   60.46%   -0.01%     
===========================================
  Files          164      165       +1     
  Lines         4930     4940      +10     
===========================================
+ Hits          2981     2987       +6     
- Misses        1949     1953       +4
Impacted Files Coverage Δ
...monkey_island/cc/environment/environment_config.py 96.00% <0.00%> (-1.78%) ⬇️
...y_island/cc/environment/server_config_generator.py 40.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f3c1b9...731239f. Read the comment docs.

@VakarisZ VakarisZ merged commit 7107e96 into guardicore:develop Sep 1, 2020
@VakarisZ VakarisZ deleted the ms08-067 branch October 15, 2020 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@ShayNehmad ShayNehmad ShayNehmad approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VakarisZ @ShayNehmad