Skip to content

Conversation

VakarisZ
Copy link
Contributor

What does this PR do?

Fixes #801
Fixes MS08-067 bugs.

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?

Testing Checklist

  • Added relevant unit tests?
  • Have you successfully tested your changes locally? Elaborate:
    image
    image

Explain Changes

Are the commit messages enough? If not, elaborate.

Comment on lines +4 to +6
import pythoncom

pythoncom.CoInitialize()
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes:

2020-08-25 16:08:37,434 [1448:10092:DEBUG] win_ms08_067.start.113: Initiating exploit connection (ncacn_np:192.168.56.3[\pipe\browser])
2020-08-25 16:08:45,503 [1448:10092:DEBUG] win_ms08_067._exploit_host.211: Error exploiting victim VictimHost('192.168.56.3'): ([Errno Connection error (192.168.56.3:445)] [WinError 10061] No connection could be made because the target machine actively refused it)
Exception in thread Thread-7:
Traceback (most recent call last):
  File "C:\Users\Vakaris\AppData\Local\Programs\Python\Python37\lib\threading.py", line 926, in _bootstrap_inner
    self.run()
  File "C:\Users\Vakaris\AppData\Local\Programs\Python\Python37\lib\threading.py", line 870, in run
    self._target(*self._args, **self._kwargs)
  File "C:\Users\Vakaris\Desktop\infection_monkey\monkey\infection_monkey\monkey.py", line 242, in start_post_breach_phase
    self.collect_system_info_if_configured()
  File "C:\Users\Vakaris\Desktop\infection_monkey\monkey\infection_monkey\monkey.py", line 254, in collect_system_info_if_configured
    system_info_collector = SystemInfoCollector()
  File "C:\Users\Vakaris\Desktop\infection_monkey\monkey\infection_monkey\system_info\__init__.py", line 39, in __init__
    from .windows_info_collector import WindowsInfoCollector
  File "C:\Users\Vakaris\Desktop\infection_monkey\monkey\infection_monkey\system_info\windows_info_collector.py", line 13, in <module>
    from common.utils.wmi_utils import WMIUtils
  File "C:\Users\Vakaris\Desktop\infection_monkey\monkey\common\utils\wmi_utils.py", line 4, in <module>
    import wmi
  File "C:\Users\Vakaris\AppData\Roaming\Python\Python37\site-packages\wmi.py", line 174, in <module>
    obj = GetObject("winmgmts:")
  File "C:\Users\Vakaris\AppData\Roaming\Python\Python37\site-packages\win32com\client\__init__.py", line 72, in GetObject
    return Moniker(Pathname, clsctx)
  File "C:\Users\Vakaris\AppData\Roaming\Python\Python37\site-packages\win32com\client\__init__.py", line 87, in Moniker
    moniker, i, bindCtx = pythoncom.MkParseDisplayName(Pathname)
pywintypes.com_error: (-2147221020, 'Invalid syntax', None, None)

@codecov
Copy link

codecov bot commented Aug 27, 2020

Codecov Report

Merging #807 into develop will increase coverage by 0.14%.
The diff coverage is 94.73%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #807      +/-   ##
===========================================
+ Coverage    60.32%   60.46%   +0.14%     
===========================================
  Files          161      164       +3     
  Lines         4900     4930      +30     
===========================================
+ Hits          2956     2981      +25     
- Misses        1944     1949       +5     
Impacted Files Coverage Δ
monkey/common/utils/shellcode_obfuscator.py 87.50% <87.50%> (ø)
monkey/common/utils/test_shellcode_obfuscator.py 100.00% <100.00%> (ø)
monkey/common/data/post_breach_consts.py 100.00% <0.00%> (ø)
monkey/common/data/api_url_consts.py 100.00% <0.00%> (ø)
monkey/infection_monkey/control.py 21.10% <0.00%> (+0.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 634dab3...8f3c1b9. Read the comment docs.

@VakarisZ VakarisZ merged commit fc0742f into guardicore:develop Aug 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Monkey flagged on Windows Defender with signature Exploit:Python/MS08067.G!MSR and Trojan:Win32:Wacatac.D6!ml
2 participants