Skip to content

Conversation

shreyamalviya
Copy link
Contributor

If the post-breach results have no changes, nothing is returned from aggregateShellStartupPba() which causes a rendering issue (te replicate, try running only the trap command PBA).

This makes sure the results are returned back as it is if there are no changes.

@codecov
Copy link

codecov bot commented Aug 4, 2020

Codecov Report

Merging #762 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #762   +/-   ##
========================================
  Coverage    60.31%   60.31%           
========================================
  Files          161      161           
  Lines         4899     4899           
========================================
  Hits          2955     2955           
  Misses        1944     1944           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3790ee...5817226. Read the comment docs.

Copy link
Contributor

@ShayNehmad ShayNehmad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved - but please create an issue about JS unit testing. The fact that we're testing our backend logic and not our frontend is pretty wild when you think about it.

Copy link
Contributor

@VakarisZ VakarisZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@VakarisZ VakarisZ merged commit d6264e9 into guardicore:develop Aug 5, 2020
@shreyamalviya shreyamalviya deleted the pba-report-bug branch September 2, 2020 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants