Skip to content

Add T1154 attack technique (trap command) #698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 13, 2020
Merged

Add T1154 attack technique (trap command) #698

merged 3 commits into from
Jul 13, 2020

Conversation

shreyamalviya
Copy link
Contributor

Fixes #697

@codecov
Copy link

codecov bot commented Jun 29, 2020 •
edited
Loading

Codecov Report

Merging #698 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #698   +/-   ##
========================================
  Coverage    59.89%   59.89%           
========================================
  Files          147      147           
  Lines         4787     4787           
========================================
  Hits          2867     2867           
  Misses        1920     1920
Impacted Files Coverage Δ
monkey/monkey_island/cc/services/config_schema.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c255ec...e6b3613. Read the comment docs.

ShayNehmad
ShayNehmad suggested changes Jun 29, 2020
View reviewed changes
VakarisZ
VakarisZ reviewed Jul 1, 2020
View reviewed changes
VakarisZ
VakarisZ requested changes Jul 1, 2020
View reviewed changes
Copy link
Contributor

@VakarisZ VakarisZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, quality code! But make sure to at least reply to my comments before merging

@shreyamalviya shreyamalviya mentioned this pull request Jul 10, 2020
Closed
ShayNehmad
ShayNehmad approved these changes Jul 12, 2020
View reviewed changes
Copy link
Contributor

@ShayNehmad ShayNehmad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@shreyamalviya shreyamalviya merged commit 7415a5e into guardicore:develop Jul 13, 2020
@shreyamalviya shreyamalviya deleted the T1154 branch August 3, 2020 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VakarisZ VakarisZ VakarisZ requested changes

+1 more reviewer

@ShayNehmad ShayNehmad ShayNehmad approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add "Trap" attack technique (T1154)
3 participants
@shreyamalviya @VakarisZ @ShayNehmad