485/handle missing binaries #670
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #670 +/- ##
========================================
Coverage 56.62% 56.62%
========================================
Files 120 120
Lines 4044 4044
========================================
Hits 2290 2290
Misses 1754 1754 Continue to review full report at Codecov.
|
| <i className="glyphicon glyphicon-info-sign" style={{'marginRight': '5px'}}/> | ||
| Some Monkey binaries are not found where they should be...<br/> | ||
| Try downloading them from <a href="https://github.com/guardicore/monkey/releases/latest" target="blank">here</a>, | ||
| at the bottommost section titled "Assets". |
There was a problem hiding this comment.
Ideally we should add "... and place them in monkey/monkey_island/cc/binaries directory."
There was a problem hiding this comment.
I wish I could make the directory path look like that, I used italics instead 🙄
There was a problem hiding this comment.
You can do this using import marked from 'marked'; and then styling your text using Markdown. You can see an example of this in monkey_island/cc/ui/src/components/attack/techniques/MitigationsComponent.js.
There was a problem hiding this comment.
Alternatively, use a div with the className="label"
There was a problem hiding this comment.
I simply used <code> :)
What is this?
Fixes #485 .
Add any further explanations here.
Checklist
Proof that it works
If applicable, add screenshots or log transcripts of the feature working
Changes
Are the commit messages enough? If not, elaborate.