-
Notifications
You must be signed in to change notification settings - Fork 807
Map create user PBA to ATT&CK matrix #582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Map create user PBA to ATT&CK matrix #582
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #582 +/- ##
========================================
Coverage 57.60% 57.60%
========================================
Files 116 116
Lines 3892 3892
========================================
Hits 2242 2242
Misses 1650 1650
Continue to review full report at Codecov.
|
1d456fb
to
2394f41
Compare
monkey/monkey_island/cc/services/attack/technique_reports/T1136.py
Outdated
Show resolved
Hide resolved
monkey/monkey_island/cc/services/attack/technique_reports/T1136.py
Outdated
Show resolved
Hide resolved
monkey/monkey_island/cc/services/attack/technique_reports/T1136.py
Outdated
Show resolved
Hide resolved
monkey/monkey_island/cc/ui/src/components/pages/ConfigurePage.js
Outdated
Show resolved
Hide resolved
monkey/monkey_island/cc/ui/src/components/pages/ConfigurePage.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job! Most of work you did is in the right direction, now you just need to finish/polish :) Post some screenshots once you get it working and feel free to ask for details on slack!
Looks good. What you need to do before we merge is 1. Test if my bugfix works and remove redundant code that does the same (maps post breach actions to attack config) 2. Test your changes if you haven't already. 3. Make Travis CI build pass. If you want more info about it feel free to ask on slack. |
e8b8d62
to
565e918
Compare
T1136: Create account
T1136: Create account
T1136: Create account
T1136: Create account
"Create Account" turned off in the ATT&CK matrix config -> "Back door user" turns off in the PBA config section ... and vice-versa
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job!
Forgot to add it back on undoing previous changes
565e918
to
3bfdcb9
Compare
Fixes #579
Implemented changes 1, 2, 4 from the following (mentioned in the issue):Implemented all changes mentioned in the issue:
TODO: 3