Skip to content

Conversation

shreyamalviya
Copy link
Contributor

@shreyamalviya shreyamalviya commented Mar 26, 2020

Fixes #579

Implemented changes 1, 2, 4 from the following (mentioned in the issue):
Implemented all changes mentioned in the issue:

Let's add this PBA to the matrix as Create Account attack technique.

  1. The "Create Account" technique should be present in attack matrix and user should be able to toggle it.
  2. On hover a brief with information about this particular attack technique should appear.
  3. This technique should be mapped with "Back door user" post breach action. This means that when "Create Account" is turned off, "Back door user" should turn off and vice versa.
  4. After exploitation, "Create Account" technique should be present on the ATT&CK report page.

TODO: 3

@codecov
Copy link

codecov bot commented Mar 26, 2020

Codecov Report

Merging #582 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #582   +/-   ##
========================================
  Coverage    57.60%   57.60%           
========================================
  Files          116      116           
  Lines         3892     3892           
========================================
  Hits          2242     2242           
  Misses        1650     1650           
Impacted Files Coverage Δ
monkey/monkey_island/cc/services/config_schema.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67c8b48...3bfdcb9. Read the comment docs.

@shreyamalviya shreyamalviya force-pushed the map-create-user-pba-to-matrix branch 2 times, most recently from 1d456fb to 2394f41 Compare April 12, 2020 16:15
@VakarisZ VakarisZ self-requested a review April 17, 2020 13:58
Copy link
Contributor

@VakarisZ VakarisZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! Most of work you did is in the right direction, now you just need to finish/polish :) Post some screenshots once you get it working and feel free to ask for details on slack!

@VakarisZ
Copy link
Contributor

Looks good. What you need to do before we merge is 1. Test if my bugfix works and remove redundant code that does the same (maps post breach actions to attack config) 2. Test your changes if you haven't already. 3. Make Travis CI build pass. If you want more info about it feel free to ask on slack.

@shreyamalviya shreyamalviya force-pushed the map-create-user-pba-to-matrix branch from e8b8d62 to 565e918 Compare April 27, 2020 17:14
@shreyamalviya shreyamalviya marked this pull request as ready for review April 27, 2020 17:20
@shreyamalviya shreyamalviya requested a review from VakarisZ May 1, 2020 11:56
Copy link
Contributor

@VakarisZ VakarisZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

Forgot to add it back on undoing previous changes
@shreyamalviya shreyamalviya force-pushed the map-create-user-pba-to-matrix branch from 565e918 to 3bfdcb9 Compare May 4, 2020 09:00
@VakarisZ VakarisZ merged commit f3ec436 into guardicore:develop May 4, 2020
@shreyamalviya shreyamalviya deleted the map-create-user-pba-to-matrix branch August 3, 2020 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ATT&CK: create user
2 participants