Bugfix/handle missing curl wget fixes #503 #524
Conversation
2 - Added option to download with either curl or wget
| exists() { | ||
| command -v "$1" >/dev/null 2>&1 | ||
| } | ||
|
|
There was a problem hiding this comment.
Yeah, it's prep for later code. I can remove from this PR but it'll just sneak back in later on
There was a problem hiding this comment.
Then leave it, but I'm giving myself a gold star for effort 🌟
| if exists curl; then | ||
| curl --output mongodb.tgz ${tgz_url} | ||
| else | ||
| echo 'Your system has neither curl nor wget, exiting' |
There was a problem hiding this comment.
We're not checking wget so this error message is incorrect. We should also add "To fix this, please run\n apt install curl\n and re-run this script"
There was a problem hiding this comment.
Woops, typo. WIll be fixed.
Wat |
| exit 1 | ||
| } | ||
|
|
||
| if exists wget; then |
There was a problem hiding this comment.
Notice that mongodb is installed after some wget calls in the deployment scripts, so it would be best to also add the same check to the deploy_linux.sh
|
@VakarisZ take a look and test please. If ok, I want to merge this then work on removing need for further downloads |
What is this?
Fixes #503 by adding option to use wget or curl as long as one is installed.
Also took the time to cleanup the script.
Checklist
Proof that it works
None yet