Fix plugin type value in grid #3649
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
38 tasks
ordabach
reviewed
Sep 4, 2023
| @@ -34,6 +34,13 @@ const getPluginsGridHeaders = (getRowActions) => [ | |||
| } | |||
| ] | |||
|
|
|||
| enum pluginTypeHumanReadable { | |||
There was a problem hiding this comment.
Do we need an enum for that?
Is there a chance that the type coming from the server will have a different name without the underscore?
E.g.:
from server --> Credentials_Collector
in ui --> Credentials Collector
can't we just replace the underscore with space and cap each word?
There was a problem hiding this comment.
Since these are values that aren't expected to change, I'd rather skip the extra logic. Even if something about how we display the name ever changes, this is easier to rework than trying to modify and debug the logic.
There was a problem hiding this comment.
Aren't expected by who? The table is a display element, nothing should expect it's columns to correspond to the plugin data.
VakarisZ
requested changes
Sep 4, 2023
VakarisZ
requested changes
Sep 4, 2023
Example: Credentials_Collector -> Credentials Collector
5ac46d3 to
b2e4044
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Make plugin type values human readable in plugin grid (removes underscores)
#3418
PR Checklist
Was the CHANGELOG.md updated to reflect the changes?Was the documentation framework updated to reflect the changes?Testing Checklist
Added relevant unit tests?Do all unit tests pass?Do all end-to-end tests pass?