Skip to content

Remove search bar label #3648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 4, 2023
Merged

Remove search bar label #3648

merged 4 commits into from
Sep 4, 2023

Conversation

shreyamalviya
Copy link
Contributor

What does this PR do?

Removes redundant search bar label
#3418

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?
  • Have you checked that you haven't introduced any duplicate code?

Testing Checklist

  • Added relevant unit tests?
  • Do all unit tests pass?
  • Do all end-to-end tests pass?
  • Any other testing performed?

    Tested by building UI

  • If applicable, add screenshots or log transcripts of the feature working

image

@shreyamalviya shreyamalviya mentioned this pull request Sep 4, 2023
Closed
38 tasks
ordabach
ordabach requested changes Sep 4, 2023
View reviewed changes
Copy link
Contributor

@ordabach ordabach left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of removing it completely, just pass an empty label when using the component.
<SearchBar setQuery={onSearchChanged} label=""/>

@shreyamalviya shreyamalviya force-pushed the 3418-remove-search-bar-title branch from f55084a to fe5a31f Compare September 4, 2023 08:17
@ilija-lazoroski ilija-lazoroski force-pushed the 3418-remove-search-bar-title branch from fe5a31f to 187967f Compare September 4, 2023 09:18
ilija-lazoroski pushed a commit that referenced this pull request Sep 4, 2023
@shreyamalviya @ilija-lazoroski
UI: Pass empty label to SearchBar in plugin grids
3fcc266 
Issue: #3418
PR: #3648
@ilija-lazoroski ilija-lazoroski force-pushed the 3418-remove-search-bar-title branch from 187967f to 3fcc266 Compare September 4, 2023 09:19
@VakarisZ VakarisZ force-pushed the 3418-remove-search-bar-title branch 2 times, most recently from cb23718 to 4fa108c Compare September 4, 2023 09:34
@VakarisZ VakarisZ force-pushed the 3418-remove-search-bar-title branch from 4fa108c to c952f42 Compare September 4, 2023 13:25
@VakarisZ VakarisZ merged commit 6767e95 into 3418-plugin-installation-screen Sep 4, 2023
@VakarisZ VakarisZ deleted the 3418-remove-search-bar-title branch September 4, 2023 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VakarisZ VakarisZ VakarisZ approved these changes

@ordabach ordabach ordabach approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shreyamalviya @VakarisZ @ordabach @ilija-lazoroski