Skip to content

Conversation

shreyamalviya
Copy link
Contributor

@shreyamalviya shreyamalviya commented Jul 26, 2023

What does this PR do?

All of the build scripts for single-vendored mock plugins under tests/ were the same. This PR deletes them and adds a single build script which accepts the plugin directory as an argument.

Fixes #3390

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?
  • Have you checked that you haven't introduced any duplicate code?

Testing Checklist

  • Added relevant unit tests?
  • Do all unit tests pass?
  • Do all end-to-end tests pass?
  • Any other testing performed?

    Tested by {Running the Monkey locally with relevant config/running Island/...}

  • If applicable, add screenshots or log transcripts of the feature working

@shreyamalviya shreyamalviya force-pushed the 3390-consolidate-mock-plugin-build-scripts branch 2 times, most recently from 2c5a743 to 06906de Compare July 26, 2023 08:19
@mssalvatore mssalvatore force-pushed the 3390-consolidate-mock-plugin-build-scripts branch from 06906de to 50bb98d Compare July 26, 2023 11:12
@mssalvatore mssalvatore merged commit 50bb98d into develop Jul 26, 2023
@shreyamalviya shreyamalviya deleted the 3390-consolidate-mock-plugin-build-scripts branch July 26, 2023 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Define payloads plugin interface
3 participants