Skip to content

Filter Agent events by tag #3512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 17, 2023
Merged

Filter Agent events by tag #3512

merged 5 commits into from
Jul 17, 2023

Conversation

shreyamalviya
Copy link
Contributor

What does this PR do?

Fixes #3396

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?
  • Have you checked that you haven't introduced any duplicate code?

Testing Checklist

  • Added relevant unit tests?
  • Do all unit tests pass?
  • Do all end-to-end tests pass?
  • Any other testing performed?

    Tested by running Island and querying endpoints manually

  • If applicable, add screenshots or log transcripts of the feature working

@shreyamalviya shreyamalviya force-pushed the 3396-filter-events-by-tag branch from cd1b033 to 82604c8 Compare July 17, 2023 11:40
@shreyamalviya shreyamalviya merged commit 24768c6 into develop Jul 17, 2023
@shreyamalviya shreyamalviya deleted the 3396-filter-events-by-tag branch July 17, 2023 11:41
mssalvatore
mssalvatore requested changes Jul 17, 2023
View reviewed changes
monkey/monkey_island/cc/resources/agent_events.py
Comment on lines +153 to +155
events_by_tag: Sequence[
AbstractAgentEvent
] = self._agent_event_repository.get_events_by_tag(tag)
Copy link
Collaborator

@mssalvatore mssalvatore Jul 17, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT: A minor performance improvement might be to extract this as a method and just say return events_by_type

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think I understand. Extract what exactly?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mssalvatore mssalvatore mssalvatore requested changes

@ilija-lazoroski ilija-lazoroski ilija-lazoroski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Filter events by tag
3 participants
@shreyamalviya @ilija-lazoroski @mssalvatore